bug#5481: 23.1; insert-kbd-macro: does not write key-binding code

[Chong Yidong]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I see the problem.  On further examination, there was already code in
>> macro.el that was supposed to handle this, but it was broken.  I've
>> checked in a fix.  Thanks for the bug report, and for the follow-up.
> [...]
>>   * src/keymap.c (Fwhere_is_internal): Use Fequal to compare
>>   definitions, so that keyboard macros are correctly handled
>>   (Bug#5481).
>
> Could you explain why Fequal is necessary there?  It should only make
> a difference if we're comparing one macro (ie. vector) against another
> identical macro, but IIUC that shouldn't be the case here.

We are indeed comparing one macro against another macro.  For a macro
bound to a key, (key-binding KEY-BOUND-TO-A-MACRO) returns the lambda
form of the macro.  The function where_is_internal_1 uses Fequal
(keymap.c:3001), and it locates the correct binding if you give the
lambda form as the `definition' argument.

But the binding found by where_is_internal was tossed aside in
Fwhere_is_internal because the result of shadow_lookup was compared
using EQ---clearly an incorrect step.  That's the part I changed.