[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#4117: 23.1; isearch + isearch-allow-scroll loses shift
From: |
Juri Linkov |
Subject: |
bug#4117: 23.1; isearch + isearch-allow-scroll loses shift |
Date: |
Mon, 17 Aug 2009 03:47:57 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu) |
>> It's interesting that after loading s-region.el, your reported case
>> works correctly without fixes.
>>
>> So it seems the current core shift-selection is not the exact
>> re-implementation of s-region.el.
>
> I still believe that the problem is somewhere in how
> `isearch-other-meta-char' restores the key. FWIW, here is my hack; I
> can't even explain how it works since I was basically guessing my way
> trying to get the stupid thing to work.
>
> At least in v22, this would cause the key that is used to exit isearch
> to be replayed twice -- for example, using `C-x 2' would happen twice.
> It just happens that I'm personally much more likely to shift-arrow my
> way out of isearch than I am to splitting the window.
Could you try the following hack:
Index: lisp/isearch.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/isearch.el,v
retrieving revision 1.345
diff -u -r1.345 isearch.el
--- lisp/isearch.el 14 Feb 2009 09:04:46 -0000 1.345
+++ lisp/isearch.el 17 Aug 2009 00:47:38 -0000
@@ -1900,6 +1905,12 @@
((and isearch-allow-scroll
(progn (setq key (isearch-reread-key-sequence-naturally
keylist))
(setq keylist (listify-key-sequence key))
+ (when this-command-keys-shift-translated
+ (setq keylist (list
+ (event-convert-list
+ (append (cons 'shift (event-modifiers
keylist))
+ (list (event-basic-type
keylist))))))
+ (setq this-command-keys-shift-translated nil))
(setq main-event (aref key 0))
(setq scroll-command (isearch-lookup-scroll-key key))))
;; From this point onwards, KEY, KEYLIST and MAIN-EVENT hold a
--
Juri Linkov
http://www.jurta.org/emacs/
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Eli Barzilay, 2009/08/11
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Juri Linkov, 2009/08/12
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Eli Barzilay, 2009/08/12
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Juri Linkov, 2009/08/15
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Eli Barzilay, 2009/08/15
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift,
Juri Linkov <=
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Eli Barzilay, 2009/08/16
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Stefan Monnier, 2009/08/17
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Eli Barzilay, 2009/08/17
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Juri Linkov, 2009/08/20
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Juri Linkov, 2009/08/20
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Stefan Monnier, 2009/08/20
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Juri Linkov, 2009/08/20
- bug#4117: 23.1; isearch + isearch-allow-scroll loses shift, Stefan Monnier, 2009/08/20