[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#1537: diff-mode for git patches trouble
From: |
Stefan Monnier |
Subject: |
bug#1537: diff-mode for git patches trouble |
Date: |
Fri, 12 Dec 2008 14:08:19 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) |
severity 1537 wishlist
thanks
>> Of course, in the general case the problem is insoluble (e.g. if you
>> edit the line with the "--"), but clearly we can do better in the
>> "normal" case.
> Probably it was incorrect to post this feature here. In fact it's git
> problem but not emacs.
No, it definitely has its place here: while it's true that Git's output
is not very friendly to patch-editing as supported by diff-mode, the
output is formally correct and unambiguous.
And your example of changes is also unambiguous, so you can definitely
argue that Emacs should behave correctly in this case.
Stefan