[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c
From: |
Eli Zaretskii |
Subject: |
bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c |
Date: |
Wed, 03 Dec 2008 20:30:30 +0200 |
> Date: Wed, 3 Dec 2008 07:24:11 -0800 (PST)
> From: Dan Nicolaescu <dann@ics.uci.edu>
> Cc: 1483@emacsbugs.donarmstrong.com
>
> jasonr@f2s.com writes:
>
> > Quoting Dan Nicolaescu <dann@ics.uci.edu>:
> >
> > > NO_SOCKETS_IN_FILE_SYSTEM is the same as WINDOWSNT, so better replace it
> > > and have one less identifier to worry about.
> >
> > Does DOS have unix domain sockets?
>
> Is DOS using emacsclient?
No, it doesn't. And probably never will (emacsclient does not work at
all in the MS-DOS port).
But I agree with Jason and Juanma: replacing the above symbol with
just WINDOWSNT gains very little, but obfuscates the condition being
tested. If anything, I'd support the opposite changes: replace each
and every ugly system name such as WINDOWSNT with a meaningful symbol
whose name would explain what is the underlying (mis)feature.
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Dan Nicolaescu, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, jasonr, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Dan Nicolaescu, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Juanma Barranquero, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Dan Nicolaescu, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Juanma Barranquero, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Dan Nicolaescu, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Juanma Barranquero, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Juanma Barranquero, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c, Eli Zaretskii, 2008/12/03
- bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c,
Eli Zaretskii <=