[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#789: find-function fails on advised subrs
From: |
martin rudalics |
Subject: |
bug#789: find-function fails on advised subrs |
Date: |
Sat, 08 Nov 2008 22:54:18 +0100 |
User-agent: |
Thunderbird 2.0.0.16 (Windows/20080708) |
> Hi martin, I finally tried this...
... and I've forgotten all about it ;-)
>
>> ! (cond
>> ! ((and (symbolp fun-or-var) (featurep 'advice)
>> ! (ad-get-advice-info fun-or-var))
>> ! (setq advised t))
>> ! ((not type)
>> ! (setq fun-or-var (indirect-function fun-or-var))))
>
> This fails if I have an alias to an advised function.
>
>> ! ;; Get the real definition.
>> ! (def (if (symbolp real-function)
>> ! (symbol-function real-function)
>> ! function))
>> ! file-name string aliases)
>
> file-name and string seem unused.
>
>> ! (cond
>> ! (advised
>> ! (message "This function is advised"))
>
> Should this function be printing if something is advised?
> Again, what about aliases to advised functions?
If you can think of an easy fix for these, please go ahead. Otherwise,
I'll look into this next week.
martin