bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#690: 23.0.60; Function origin file misremembered


From: martin rudalics
Subject: bug#690: 23.0.60; Function origin file misremembered
Date: Mon, 11 Aug 2008 17:56:24 +0200
User-agent: Thunderbird 2.0.0.16 (Windows/20080708)

> I do not see much value in abbreviating the file name at all; unless
> that is important for other features to work, I find that the original
> file name should be preserved in case of doubt. (symbol-file
> 'prolog-mode) correctly evaluates to "/Users/mt/prolog.el", so this is
> what should be shown. Otherwise, even future changes to load-path could
> lead to distorted file origins of functions that are already loaded.

Do people see problems if we do not simplify the filename when the
libname is not a compiled file?

martin
*** help-fns.el.~1.123.~        2008-07-28 15:19:09.000000000 +0200
--- help-fns.el 2008-08-11 17:49:09.375000000 +0200
***************
*** 225,234 ****
        (let ((libname (file-name-nondirectory file)))
        ;; Now convert that back to a file name and see if we get
        ;; the original one.  If so, they are equivalent.
!       (if (equal file (locate-file libname load-path '("")))
!           (if (string-match "[.]elc\\'" libname)
!               (substring libname 0 -1)
!             libname)
          file))))
  
  (defun find-source-lisp-file (file-name)
--- 225,233 ----
        (let ((libname (file-name-nondirectory file)))
        ;; Now convert that back to a file name and see if we get
        ;; the original one.  If so, they are equivalent.
!       (if (and (equal file (locate-file libname load-path '("")))
!                (string-match "[.]elc\\'" libname))
!           (substring libname 0 -1)
          file))))
  
  (defun find-source-lisp-file (file-name)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]