Re: Emacs-22.1 compilation-error-regexp

[Nick Roberts]

Bob McIsaac writes:
 > The compilation-error-regexp works for gcc output but not for
 > Openwatcom. However, it worked fine for emacs-21. It seems the regexp
 > no longer accepts parentheses around the line number.
 > 
 > ----- gcc example is ok ----
 > -*- mode: compilation; default-directory: "c:/altm/acp-7-3/build/" -*-
 > ../src/vi/vi_main.c:53: `xint' undeclared (first use in this function)
 > ../src/vi/vi_main.c:53: (Each undeclared identifier is reported only once
 > 
 > ------- Open Watcom Make Version 1.7 -- not ok because of line number ======
 > ..\src\ctrl\lister.c(109): Error! E1009: Expecting ';' but found '{'
 > ..\src\ctrl\lister.c(120): Warning! W201: Unreachable code
 > ..\src\ctrl\lister.c(109): Warning! W131: No prototype found for 
 > function 'xif'

This isn't really my area but it's such a concise bug report it deserves a
reply.  I've checked the changes below into the trunk.  Can you please confirm
that they work for you?  In particular, when the filename is absolute, e.g.,

c:\src\ctrl\lister.c(109): ....

-- 
Nick                                           http://www.inet.net.nz/~nickrob


*** compile.el.~1.468.~ 2008-05-03 21:40:59.000000000 +1200
--- compile.el  2008-05-05 23:48:46.000000000 +1200
*************** File = \\(.+\\), Line = \\([0-9]+\\)\\(?
*** 323,328 ****
--- 323,331 ----
      (sun-ada
       "^\\([^, \n\t]+\\), line \\([0-9]+\\), char \\([0-9]+\\)[:., \(-]" 1 2 3)
  
+     (watcom
+      "\\(\\(?:[a-zA-Z]:\\)?[^:(\t\n]+\\)(\\([0-9]+\\)): \\(?:Error! 
E[0-9]+\\|Warning! W[0-9]+\\):" 1 2)
+ 
      (4bsd
       "\\(?:^\\|::  \\|\\S ( \\)\\(/[^ \n\t()]+\\)(\\([0-9]+\\))\
  \\(?:: \\(warning:\\)?\\|$\\| ),\\)" 1 2 nil (3))


*** compilation.txt.~1.20.~     2008-02-26 00:21:25.000000000 +1300
--- compilation.txt     2008-05-05 23:49:17.000000000 +1200
*************** keyboard handler.c(537) : warning C4005:
*** 263,268 ****
--- 263,276 ----
  d:\tmp\test.c(23) : error C2143: syntax error : missing ';' before 'if'
  
  
+ * Open Watcom
+ 
+ symbol: watcom
+ 
+ ..\src\ctrl\lister.c(109): Error! E1009: Expecting ';' but found '{'
+ ..\src\ctrl\lister.c(120): Warning! W201: Unreachable code
+ 
+ 
  * Oracle pro*c
  
  symbol: oracle