[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: View-quit in *Help* restores wrong window when display-buffer-reuse-
From: |
martin rudalics |
Subject: |
Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t |
Date: |
Wed, 24 Oct 2007 08:32:09 +0200 |
User-agent: |
Mozilla Thunderbird 1.0 (Windows/20041206) |
>>>emacs -Q
>>>C-h find-file
>>>C-x 1
>>>C-x b *Help*
>>>q
>>>
>>>-> "q" has no effect at all
>>
>>I cannot reproduce this, my Emacs has "q" display *scratch* instead.
>
>
> I see the above behaviour in Emacs-22.1. After applying your patches,
> it's better in that the above works correctly, but if I repeat the
> `C-x b *Help*' a second time, then `q' has no effect. Do you see that?
Yes. The problem is that `view-exit-action' is reset to nil after
exiting once. This is hardly TRT when the buffer is _not_ killed.
Hence we could simplify the tail of `view-mode-exit' to
(when exit-action
(funcall exit-action buffer))
(force-mode-line-update))))
Since `view-exit-action' is buffer-local I don't see any problems either
when the buffer _is_ killed.
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, (continued)
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, Glenn Morris, 2007/10/18
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, martin rudalics, 2007/10/18
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, Glenn Morris, 2007/10/18
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, martin rudalics, 2007/10/19
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, Glenn Morris, 2007/10/19
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, martin rudalics, 2007/10/20
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, Glenn Morris, 2007/10/23
- Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t,
martin rudalics <=
Re: View-quit in *Help* restores wrong window when display-buffer-reuse-frames is t, David Reitter, 2007/10/22