Assertion failure during bootstrap on OSX

[Andrew Beekhof]

Hi,

I get the following assertion failure when running "make bootstrap" on  
OSX with the latest code from CVS.

unexmacosx.c:454: failed assertion `filesize <= ranges->size'
make[2]: *** [bootstrap-emacs] Abort trap (core dumped)

The relevant code is:

static void
unexec_regions_recorder (task_t task, void *rr, unsigned type,
                         vm_range_t *ranges, unsigned num)
{
  vm_address_t p;
  vm_size_t filesize;

  while (num && num_unexec_regions < MAX_UNEXEC_REGIONS)
    {
      /* Subtract the size of trailing null pages from filesize.  It
         can be smaller than vmsize in segment commands.  In such a
         case, trailing pages are initialized with zeros.  */
      for (p = ranges->address + ranges->size; p > ranges->address;
           p -= sizeof (int))
        if (*(((int *) p)-1))
          break;
      filesize = ROUNDUP_TO_PAGE_BOUNDARY (p - ranges->address);

      assert (filesize <= ranges->size);

      unexec_regions[num_unexec_regions].filesize = filesize;
      unexec_regions[num_unexec_regions++].range = *ranges;
      printf ("%#10lx (sz: %#8lx/%#8lx)\n", (long) (ranges->address),
              (long) filesize, (long) (ranges->size));
      ranges++; num--;
    }
}


In case it might help, I added some extra logging to output the  
relevant variables:
	p: 0x5ffd96, ranges->address: 0x5fc080, filesize=16384, ranges- 
>size=16138


Output leading up to this error was:

Dumping under names emacs and emacs-22.1.50
--- List of All Regions ---
   address     size prot maxp
         0   0x1000 none none
    0x1000 0x18b000 r x  rwx
  0x18c000 0x11f000 rw   rwx
  0x2ab000  0x3e000 rw   rwx
  0x2e9000   0x3000 rwx  rwx
  0x2ec000  0x82000 r    rwx
  0x36e000   0x1000 none rwx
  0x36f000   0x1000 rw   rwx
  0x370000   0x1000 none rwx
  0x371000   0x6000 rw   rwx
  0x377000   0x1000 none rwx
  0x378000   0x1000 rw   rwx
  0x379000   0x1000 none rwx
  0x37a000   0x5000 rw   rwx
  0x37f000   0x3000 rw   rwx
  0x382000   0x5000 r    rwx
  0x387000   0x1000 rw   rwx
  0x388000  0x1c000 rw   rwx
  0x3a4000   0x2000 rw   rwx
  0x3a6000   0x2000 rw   rwx
  0x3a8000   0x1000 rw   rwx
  0x3a9000   0x1000 rw   rwx
  0x3aa000   0x1000 rw   rwx
  0x3ab000   0x1000 rw   rwx
  0x3ac000   0x1000 rw   rwx
  0x3ad000   0x1000 rw   rwx
  0x3ae000   0x1000 rw   rwx
  0x3af000   0x1000 rw   rwx
  0x3b0000   0x1000 rw   rwx
  0x3b1000   0x1000 rw   rwx
  0x3b2000   0x1000 rw   rwx
  0x3b3000   0x1000 rw   rwx
  0x3b4000   0x1000 rw   rwx
  0x3b5000   0x1000 rw   rwx
  0x3b6000   0x1000 rw   rwx
  0x3b7000   0x1000 rw   rwx
  0x3b8000   0x1000 rw   rwx
  0x3b9000   0x1000 rw   rwx
  0x3ba000   0x1000 rw   rwx
  0x3bb000   0x1000 rw   rwx
  0x3bc000  0x1f000 rw   rwx
  0x3db000   0xa000 rw   rwx
  0x3e5000   0x1000 r    rw
  0x3e6000  0x19000 rw   rwx
  0x400000 0x100000 rw   rwx
  0x500000 0x100000 rw   rwx
  0x600000  0x1b000 rw   rwx
  0x61b000  0x1e000 rw   rwx
  0x639000  0x1b000 rw   rwx
  0x656000   0x5000 rw   rwx
  0x65d000   0xf000 rw   rwx
  0x66f000   0x5000 rw   rwx
  0x674000   0x5000 rw   rwx
  0x679000  0x14000 rw   rwx
  0x68d000  0x1e000 rw   rwx
  0x6ab000  0x14000 rw   rwx
  0x6c0000   0x5000 rw   rwx
  0x6c5000   0xf000 rw   rwx
  0x6d4000   0x5000 rw   rwx
  0x6dc000   0x5000 rw   rwx
  0x6e4000  0x1e000 rw   rwx
  0x702000  0x1e000 rw   rwx
  0x720000  0x1e000 rw   rwx
  0x73e000  0x1e000 rw   rwx
  0x75c000   0x5000 rw   rwx
  0x765000   0x5000 rw   rwx
  0x76b000   0x5000 rw   rwx
  0x770000   0xa000 rw   rwx
  0x77a000   0xa000 rw   rwx
  0x785000   0x9000 rw   rwx
  0x78e000   0xa000 rw   rwx
  0x79a000  0x1e000 rw   rwx
  0x7b8000   0x5000 rw   rwx
  0x7bd000   0x5000 rw   rwx
  0x7c2000   0xa000 rw   rwx
  0x7cc000   0x5000 rw   rwx
  0x7d1000   0xa000 rw   rwx
  0x7db000  0x1e000 rw   rwx
  0x7f9000   0x5000 rw   rwx
  0x800000 0x800000 rw   rwx
 0x1000000 0x400000 rw   rwx
--- List of Regions to be Dumped ---
   address     size prot maxp
         0   0x1000 none none
    0x1000 0x18b000 r x  rwx
  0x18c000 0x15d000 rw   rwx
  0x2e9000   0x3000 rwx  rwx
  0x2ec000  0x82000 r    rwx
  0x36e000   0x1000 none rwx
  0x36f000   0x1000 rw   rwx
  0x370000   0x1000 none rwx
  0x371000   0x6000 rw   rwx
  0x377000   0x1000 none rwx
  0x378000   0x1000 rw   rwx
  0x379000   0x1000 none rwx
  0x37a000   0x8000 rw   rwx
  0x382000   0x5000 r    rwx
  0x387000  0x5e000 rw   rwx
  0x3e5000   0x1000 r    rw
  0x3e6000  0x19000 rw   rwx
  0x400000 0x254000 rw   rwx
  0x656000   0x5000 rw   rwx
  0x65d000   0xf000 rw   rwx
  0x66f000  0x50000 rw   rwx
  0x6c0000  0x19000 rw   rwx
  0x6dc000   0x5000 rw   rwx
  0x6e4000  0x7d000 rw   rwx
  0x765000   0x5000 rw   rwx
  0x76b000  0x19000 rw   rwx
  0x785000  0x13000 rw   rwx
  0x79a000  0x64000 rw   rwx
  0x800000 0xc00000 rw   rwx
--- Header Information ---
Magic = 0xfeedface
CPUType = 7
CPUSubType = 3
FileType = 0x2
NCmds = 18
SizeOfCmds = 2056
Flags = 0x00000085
Highest address of load commands in input file: 0x36e000
Lowest offset of all sections in __TEXT segment:   0x1db0
--- List of Load Commands in Input File ---
# cmd              cmdsize name                address     size
0 LC_SEGMENT             56 __PAGEZERO                0   0x1000
1 LC_SEGMENT            396 __TEXT               0x1000 0x18b000
                           __text               0x2db0 0x17520d
                           __cstring          0x177fc0  0x138cb
                           __literal8         0x18b890     0xf0
                           __const            0x18b980    0x656
                           __literal4         0x18bfd8     0x1c
2 LC_SEGMENT            464 __DATA             0x18c000 0x15d000
                           __data             0x18c000 0x11d646
                           __dyld             0x2a9648      0x8
                           __const            0x2a9660   0x17c0
                           __cfstring         0x2aae20     0xb0
                           __common           0x2aaee0   0xacd1
                           __bss              0x2b5bc0  0x33199
3 LC_SEGMENT            192 __IMPORT           0x2e9000   0x3000
                           __pointers         0x2e9000   0x17d8
                           __jump_table       0x2ea800    0xeec
4 LC_SEGMENT             56 __LINKEDIT         0x2ec000  0x82000
5 LC_SYMTAB              24
6 LC_DYSYMTAB            80
7 LC_LOAD_DYLINKER       28
8 unknown                24
9 LC_UNIXTHREAD          80
10 LC_LOAD_DYLIB          88
11 LC_LOAD_DYLIB          92
12 LC_LOAD_DYLIB          56
13 LC_LOAD_DYLIB          52
14 LC_LOAD_DYLIB          52
15 LC_LOAD_DYLIB         100
16 LC_LOAD_DYLIB         104
17 LC_LOAD_DYLIB         112