Re: highlight-changes-rotate-faces sets buffer modified flag

[martin rudalics]

> Hi,
>
> Turning off highlight-changes-mode sets the buffer-modified state as well.

This could be handled as with `highlight-changes-rotate-faces'.
Unfortunately, switching `highlight-changes-mode' off will leave
`buffer-undo-list' cluttered with all sorts of remnants that make sense
iff the mode is on.  You could try as follows: Switch the mode on, do
some changes, rotate colors, switch it off, undo changes.  Changed text
may get highlighted although the mode is off.

> By the way, I do not have a lot of experience with emacs lisp. Regarding
> buffer-undo-list: would it be correct to just remove the front element
> of the list in the advice I wrote?

Better not record the change in the first place by temporarily binding
`buffer-undo-list' to t during the buffer change.

BTW, am I correct that you run `highlight-changes-rotate-faces'
interactively and not in `write-file-functions'?  In the latter case
setting the buffer-modified flag should get shadowed by the saving
primitive.