Compilation window height

[Henrik Enberg]

[My SMTP server refuses to send mail to bug-gnu-emacs@gnu.org so I have
to post this here instead.  Hope someone in charge sees it]  

In GNU Emacs 21.1.1 (i686-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 of 2001-10-21 on rocksteady
Important settings:
  value of $LC_ALL: C
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Setting the variable `compilation-window-height' causes M-x compile to
fail with the following backtrace when the value is larger than the
whole Emacs window (as can be the case when running Emacs on the
console).

Debugger entered--Lisp error: (wrong-type-argument window-live-p #<window 1>)
  select-window(#<window 1>)
  compilation-set-window-height(#<window 4 on *compilation*>)
  compile-internal("make -k " "No more errors")
  compile("make -k ")
  call-interactively(compile)

Here is a patch that fixes the problem.  I suppose this really should be
handled in the built-in `enlarge-window' for a more general approach.

--- compile.el.~1~      Wed Sep 19 22:59:24 2001
+++ compile.el  Mon Oct 22 17:39:56 2001
@@ -863,7 +863,7 @@

 (defun compilation-set-window-height (window)
   "Set the height of WINDOW according to `compilation-window-height'."
-  (and compilation-window-height
+  (and (< compilation-window-height (window-height))
        (= (window-width window) (frame-width (window-frame window)))
        ;; If window is alone in its frame, aside from a minibuffer,
        ;; don't change its height.

Henrik
-- 
I'm CONTROLLED by the CIA!!  EVERYONE is controlled by the CIA!!