Re: [bug-gawk] [PATCH] test/poundbang: Fix relative path of AWKPROG

[Michael Forney]

On Wed, May 28, 2014 at 08:52:27AM +0300, Aharon Robbins wrote:
> Hi.  Can you describe the use case that your patch is fixing, please?

Sure. If you look at the rule definition for poundbang in test/Makefile.am:1187,
you'll see that it first tries to use `pwd`/$(AWKPROG) as the interpreter for
the script.

On Linux systems, there is a limit of 128 bytes for this path. The comments for
the poundbang rule mention this, and the rule provides a fallback by using a
relative path of ../$(AWKPROG). However, if you look at the definition of
AWKPROG on line 1055, it already contains the '../' component. The result is
that when the current directory is longer than 128 bytes, gawk is looked for in
../../gawk, which lies outside the source tree.

This patch just removes the extra '../', causing it the test to work correctly
in this fallback case.

-- 
Michael Forney <address@hidden>

signature.asc
Description: Digital signature