[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/11] quote consistently and make tests pass with new quotin
From: |
Paul Eggert |
Subject: |
Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib |
Date: |
Tue, 06 Mar 2012 14:01:00 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120209 Thunderbird/10.0.1 |
On 03/06/2012 12:33 AM, Akim Demaille wrote:
> I've made the changes you asked for, but I can't push
> into gnulib. Thanks!
I looked at it one more time and have a few more (I hope minor)
suggestions: use the same comment style as the rest of the code,
avoid the need for quote_quoting_options_, add a ChangeLog entry
with style similar to gnulib's.
I think the only change relevant to Bison is you need to put in
an "&" before quote_quoting_options. If that's too much of a
pain we can declare it as an array of size 1 instead, which removes
the need for "&", though it makes the decl a bit trickier.
Proposed revised patch attached.
quote-patch.txt
Description: Text document
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/03/05
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Paul Eggert, 2012/03/05
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/03/06
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib,
Paul Eggert <=
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/03/06
- [PATCH] quote: fuse into quotearg, Paul Eggert, 2012/03/07
- Re: [PATCH] quote: fuse into quotearg, Bruno Haible, 2012/03/07
- Re: [PATCH] quote: fuse into quotearg, Akim Demaille, 2012/03/09
- Re: [PATCH] quote: fuse into quotearg, Akim Demaille, 2012/03/13
- Re: [PATCH] quote: fuse into quotearg, Paul Eggert, 2012/03/13
- Re: [PATCH] quote: fuse into quotearg, Akim Demaille, 2012/03/14
- Re: [PATCH 10/11] quote consistently and make tests pass with new quoting from gnulib, Akim Demaille, 2012/03/09