bug-binutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug ld/27433] RISC-V linker might lose relax opportunities since "again


From: wilson at gcc dot gnu.org
Subject: [Bug ld/27433] RISC-V linker might lose relax opportunities since "again" doesn't work as expected
Date: Tue, 23 Feb 2021 00:16:07 +0000

https://sourceware.org/bugzilla/show_bug.cgi?id=27433

Jim Wilson <wilson at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |wilson at gcc dot gnu.org

--- Comment #4 from Jim Wilson <wilson at gcc dot gnu.org> ---
I don't see another target that does the same thing, but I do see multiple
targets with size_stub hooks that can call ldelf_map_segments multiple times,
so clearly this should work.

Worst case, we could always increase the relax pass count.  We could have 7
passes instead of 4 for instance, where 0, 1, 2 are the same as current passes,
then 3, 4, 5 as same as 0, 1, 2 if necessary, and then pass 7 is same as
current pass 3 for alignment relaxation.  But I don't think that is necessary. 
Your patch should work.

I noticed a few minor comment typos
itslef -> itself
relxations -> relaxations
and from a previous patch that I missed
obselete -> obsolete

I'm curious how this affects link time, but since few relaxations will happen
on the second time through I don't think it will matter much.  I can check
native glibc build times after you commit the patch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]