[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug ld/26090] is_relocatable_executable isn't handled correctly
From: |
hjl.tools at gmail dot com |
Subject: |
[Bug ld/26090] is_relocatable_executable isn't handled correctly |
Date: |
Sun, 07 Jun 2020 18:01:09 +0000 |
https://sourceware.org/bugzilla/show_bug.cgi?id=26090
H.J. Lu <hjl.tools at gmail dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Incorrect exclude.exp |is_relocatable_executable
| |isn't handled correctly
--- Comment #1 from H.J. Lu <hjl.tools at gmail dot com> ---
bfd_boolean
bfd_elf_link_record_dynamic_symbol (struct bfd_link_info *info,
struct elf_link_hash_entry *h)
{
if (h->dynindx == -1)
{
struct elf_strtab_hash *dynstr;
char *p;
const char *name;
size_t indx;
/* XXX: The ABI draft says the linker must turn hidden and
internal symbols into STB_LOCAL symbols when producing the
DSO. However, if ld.so honors st_other in the dynamic table,
this would not be necessary. */
switch (ELF_ST_VISIBILITY (h->other))
{
case STV_INTERNAL:
case STV_HIDDEN:
if (h->root.type != bfd_link_hash_undefined
&& h->root.type != bfd_link_hash_undefweak)
{
h->forced_local = 1;
if (!elf_hash_table (info)->is_relocatable_executable)
^^^^^^^^^^^^^^^^ Should bfd_link_pic (info) also return TRUE?
return TRUE;
}
default:
break;
}
--
You are receiving this mail because:
You are on the CC list for the bug.