[Bug binutils/26082] infinite loop in windmc

[ralf.habacker at freenet dot de]

https://sourceware.org/bugzilla/show_bug.cgi?id=26082

--- Comment #8 from Ralf Habacker <ralf.habacker at freenet dot de> ---
(In reply to Joel Anderson from comment #7)
> I do think that it is important to note that the two new patches alter
> windmc behavior to accept a file where the period is immediately followed by
> a EOF instead of a newline or carriage return and newline. 

Thanks for this pointer.

> These types of files are rejected by current versions of mc.exe, 

Can you say from which version on this behavior was changed ? 

> which is what I was using  the 'premature EOF' attachment to test against 
> myself.

This change means that projects using the old style would have to adjust the
corresponding files, which for example requires additional maintenance work for
the Mingw maintainers at opensuse to patch all affected packages and report
this change to the corresponding projects.

> While the new patches are more forgiving to the user and perhaps a better
> way to handle the scenario, they do not match mc.exe behavior. 

> I can see arguments for both cases, but just want to make sure that it is a 
> deliberate choice to deviate windmc's behavior from that of mc.exe.

I think the best would be to extend windmc with an additional command line
option to require exact mc compatibility. Projects can use this switch to make
sure that only input files compatible to mc are usable. Without this switch,
the "windmc" specific extensions would be enabled by default, but a warning is
displayed that these files may not be compatible with mc. Project maintainers
can then decide whether or not to modify these files accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.