[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] tests: make test runner a script, not a shell function
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH 1/2] tests: make test runner a script, not a shell function |
Date: |
Tue, 21 Jun 2011 08:23:09 +0200 |
* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 11:12:23PM CEST:
> Maybe we should also say that using TESTS_ENVIRONMENT to define a custom
> test runner is now not only strongly deprecated (as it already was I hope),
No it wasn't. "test runner" is not a term I would recognize, btw.
> but also unsupported and not working anymore?
> Also, should I look for TESTS_ENVIRONMENT usages in google code search?
> I was really hoping to spae myself the pain... ;-)
Not sure. If anything, you can use regexes to avoid stuff you're not
interested in.
> > and if not, is it possible to have a compatible one (without too much
> > maintenance effort duplication)? No need to go the effort right away.
> >
> Well, we could add a new option "old-parallel-tests" or something like
> that, that causes the old code in 'check.am' (with few tweaks in order
> to support the new parsing of `.log' files) to be used instead of the
> 'test-driver' script. By refactoring some code in handle_tests(), we
> could ensure not to add any real complexity to the automake script
> (w.r.t. to my patches at least); but the duplication between 'check.am'
> and 'test-driver' will unavoidable IMHO.
Well, if we need to use a name, then the name should be for the new one.
That way you can have full backward compatibility.
> > I hope that we do not have to maintain four or more such drivers.
> >
> Me too. And I also think we should start deprecating the old "serial"
> driver ASAP (i.e., in 1.12, as I think 1.11.2 is sadly tooearly); but
> this is for another thread, and another time.
Erm, there are quite a few packages out there that can only use the
serial driver. They require tests run in a specific order, or some
tests run twice, or output not redirected.
I "fixed" Libtool a while ago, but the changed code is still quite
buggy. I don't think we can expect everyone to migrate.
Cheers,
Ralf
- Re: Automake patches for custom test drivers' support break coreutils testsuite, (continued)
- Re: Automake patches for custom test drivers' support break coreutils testsuite, Stefano Lattarini, 2011/06/18
- Re: Automake patches for custom test drivers' support break coreutils testsuite, Jim Meyering, 2011/06/18
- [PATCH 1/2] tests: make test runner a script, not a shell function (was: Automake patches for custom test drivers' support break coreutils testsuite), Stefano Lattarini, 2011/06/18
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function (was: Automake patches for custom test drivers' support break coreutils testsuite), Stefano Lattarini, 2011/06/18
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Jim Meyering, 2011/06/19
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Jim Meyering, 2011/06/19
- Message not available
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Ralf Wildenhues, 2011/06/20
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Jim Meyering, 2011/06/20
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Ralf Wildenhues, 2011/06/20
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Stefano Lattarini, 2011/06/20
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function,
Ralf Wildenhues <=
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Stefano Lattarini, 2011/06/21
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Jim Meyering, 2011/06/21
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Stefano Lattarini, 2011/06/21
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Jim Meyering, 2011/06/21
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Stefano Lattarini, 2011/06/21
- [PATCH] {master} tests: interactions between TESTS_ENVIRONMENT and LOG_COMPILER, Stefano Lattarini, 2011/06/21
- Re: [PATCH 1/2] tests: make test runner a script, not a shell function, Stefano Lattarini, 2011/06/20
- Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor, Stefano Lattarini, 2011/06/19
- Re: [PATCH v4 1/3] parallel-tests: add auxiliary script 'pt-driver', refactor, Stefano Lattarini, 2011/06/20
[PATCH v4 2/3] parallel-tests: allow custom driver scripts, Stefano Lattarini, 2011/06/16