[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] {master} Optimize tests `instspc-*.test' for speed.
From: |
Stefano Lattarini |
Subject: |
Re: [PATCHES] {master} Optimize tests `instspc-*.test' for speed. |
Date: |
Thu, 2 Dec 2010 23:12:16 +0100 |
User-agent: |
KMail/1.13.3 (Linux/2.6.30-2-686; KDE/4.4.4; i686; ; ) |
On Thursday 02 December 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Thu, Dec 02, 2010 at 06:17:49PM CET:
> > Since Savannah is up again now, I'm pinging this patch.
>
> Thanks.
>
> > I'll wait the customary 72 hours (until sunday evening) before
> > pushing, if there are no objections.
>
> I think this patch deserves a proper review. Sorry for the delay,
> I'll try to make time soonish.
>
OK. In the meantime, thanks to the Vim spellchecker, I've squashed
in these typofixes:
-*-*-*-
diff --git a/tests/instspc-tests.sh b/tests/instspc-tests.sh
index 3deac1a..d2cb932 100755
--- a/tests/instspc-tests.sh
+++ b/tests/instspc-tests.sh
@@ -71,7 +71,7 @@ case $instspc_action in
;;
generate-data)
# We'll need some definitions provided by `tests/defs-static'.
- # Temporarly disable the errexit flag, since the code in that
+ # Temporarily disable the errexit flag, since the code in that
# file might not be prepared to deal with it.
set +e
. ./defs-static || exit 1
@@ -309,7 +309,7 @@ fi
### If we are still here, we have to run a test ...
-# We'll need the full setup provided by `tests/defs'. Temporarly disable
+# We'll need the full setup provided by `tests/defs'. Temporarily disable
# the errexit flag, since the setup code might not be prepared to deal
# with it.
set +e
@@ -319,7 +319,7 @@ set -e
# But the directory set up by the `--generate-data' option should contain
# all the files we need. So remove the other files created by ./defs.
# And check we really are in a temporary `*.dir' directory in the build
-# tree, since the last thing we want is to remove soem randoom user files!
+# tree, since the last thing we want is to remove some random user files!
test -f ../defs-static && test -f ../defs || Exit 99
case `pwd` in *.dir);; *) Exit 99;; esac
rm -f *
-*-*-*-
Regards,
Stefano