Re: [PATCH 1/3] Add advanced error reporting

[Mike Frysinger]

On 26 Sep 2023 17:09, Bodo Eggert wrote:
> +/*char *advanced_errors[] = {
> +     "OK",
> +     "(generic)",
> +     "default acl exists",
> +     "User not found",
> +     "Error while looking up user",
> +     "Group not found",
> +     "Error while looking up group",
> +};*/

don't add dead code -> delete

> +char *advanced_errors[] = {

this is a global writable array of pointers.  this should be at least:

const char * const advanced_errors[] = {

but i would even go as far as marking it static and adding a helper like
get_advanced_error(int num) and have that return a const char * string.
-mike

signature.asc
Description: PGP signature